This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Update to the latest version of skn #1980
Merged
+1,008
−756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
commented
Jul 30, 2021
| export function quiltPackage({ | ||
| jestEnv = 'jsdom', | ||
| useReact = false, |
There was a problem hiding this comment.
I've removed useReact as there is no harm in enabling it for all packages
| jestTestRunner = 'jest-circus', | ||
| polyfill = true, |
There was a problem hiding this comment.
The only package that overrides this and sets it to false is polyfills because we want that package to uh, provide the polyfills.
| packageBuild({ | ||
| nodeTargets: 'node 12.14.0', | ||
| browserTargets: 'extends @shopify/browserslist-config', | ||
| }), | ||
| createProjectBuildPlugin('Quilt.PackageBuild', ({hooks}) => { |
There was a problem hiding this comment.
babelIgnorePatterns no longer exists, and we don't need to add legacy decorator support because @shopify/babel-preset already enables it correctly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sewing-kit-next has undergone some juicy changes. Simplifying and reworking its architecture and plugins. Here's a PR to pull our skn dependencies up to the latest versions. The build output of all packages remains identical to main, with the exception of some extra ts-expect-error comments added because TS is confusing itself as I haven't updated the contents of
sewing-kit-plugin-quilt- to use the latest versions of the sk packages.Stuff of note:
@sewing-kit/{config,hooks,plugins}packages have all be consolidated into the core package.plugin-javascriptand its built-in babel config is gone, replaced byplugin-babel, which requires you explicitly state the babel preset that you wan to use. Unsuprisingly we've chosen@shopify/babel-presetas the baseline babel config.typesandtypesVersionskeys in package.json now point into the build folder directlyTesting
To compare the old and new build output i did the following:
mainbranch into~/projects/quilt, Ranrm -rf .sewing-kit; git clean -f -x packages/*/build; yarn buildto generate a fresh build of main.rm -rf .sewing-kit; git clean -f -x packages/*/build; yarn buildto generate a fresh build of this branchfor PACKAGENAME in $(ls -1 packages) do; diff -ru packages/$PACKAGENAME/build ~/projects/quilt/packages/$PACKAGENAME/build -x '*.tsbuildinfo'to run diffs of every packages's build output.sewing-kit-plugin-quilt, and d.ts files no longer being generated at the root (as we now point types/typesVersions directly into the build folder)Type of change